Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subscriptions Module: add link to the Email Followers list in Calypso #4608

Merged
merged 1 commit into from
Aug 1, 2016

Conversation

eliorivero
Copy link
Contributor

Fixes #4496

Changes proposed in this Pull Request:

Adds a link to the Subscriptions module, only visible when it's active, to the Email Followers list in WordPress.com

captura de pantalla 2016-07-29 a las 18 21 26

When module is inactive, nothing is shown

captura de pantalla 2016-07-29 a las 18 21 34

#### Testing instructions: - go to Jetpack admin > Settings > Engagement and expand the Subscriptions module. If it's active, it should display a link to Email Followers in WordPress.com - nothing should be displayed in Dev Mode since the module isn't available

@eliorivero eliorivero added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. Admin Page React-powered dashboard under the Jetpack menu labels Jul 29, 2016
@eliorivero eliorivero added this to the 4.3-public-beta milestone Jul 29, 2016
@dereksmart
Copy link
Member

LGTM, Tests well :shipit:

@dereksmart dereksmart added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Aug 1, 2016
@eliorivero eliorivero merged commit 0990327 into master Aug 1, 2016
@eliorivero eliorivero deleted the add/subscriptions-link-followers-calypso branch August 1, 2016 14:21
@kraftbj kraftbj removed the [Status] Ready to Merge Go ahead, you can push that green button! label Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Admin Page React-powered dashboard under the Jetpack menu [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Admin Page: add link to wp-admin subscribers page
3 participants