Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/issue 2802 - Include private lessons in course completion count #2879

Open
wants to merge 22 commits into
base: trunk
Choose a base branch
from
Open

Fix/issue 2802 - Include private lessons in course completion count #2879

Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
e945d55
Include private lessons in course completion check
JuanchoPestana Feb 1, 2020
bf41506
Fix sniffer issues in current function
JuanchoPestana Feb 1, 2020
705ad6e
01. Course archive - fix lesson count
JuanchoPestana Apr 23, 2020
0599aaa
02. Single course - fix display private lessons
JuanchoPestana Apr 23, 2020
5a443e2
Merge branch 'master' into fix/issue-2802
JuanchoPestana Apr 23, 2020
35733ba
03. Private course - fix is_enrolled() function
JuanchoPestana Apr 23, 2020
f23ddb8
03. Private Course - fix sniffer issue
JuanchoPestana Apr 23, 2020
77dfb74
04. Single course - fix lesson count
JuanchoPestana Apr 23, 2020
052c056
05. My courses - fix private lessons not appearing
JuanchoPestana Apr 24, 2020
22d7d6a
06. Single course - fix completion status not working in private courses
JuanchoPestana Apr 24, 2020
bc236c5
07. Grading - fix dropdown not including private lessons
JuanchoPestana Apr 24, 2020
d71fc30
08. Learners Management - fix table does not include private courses
JuanchoPestana Apr 24, 2020
4cc55d6
09. Learners Management - fix table does not include private lessons
JuanchoPestana Apr 24, 2020
8b31c65
10. Dashboard - fix at a glance widget
JuanchoPestana Apr 24, 2020
cc70f3a
11. New Lesson - fix lesson prerequisite dropdown
JuanchoPestana Apr 24, 2020
b383d97
12. New Course - fix course prerequisite dropdown
JuanchoPestana Apr 24, 2020
eeb9657
13. New Lesson - fix add lesson to course order
JuanchoPestana Apr 24, 2020
b6f04e8
14. Single course module - fix error in module progress calculation
JuanchoPestana Apr 24, 2020
e19e69d
15. Modules - fix table not displaying private lessons
JuanchoPestana Apr 24, 2020
459d059
16. Authors - fix lesson count
JuanchoPestana Apr 24, 2020
53f7338
17. Teacher Notification - fix error on sending notification
JuanchoPestana Apr 24, 2020
ff62493
17. Teacher Notification - fix sniffer issue
JuanchoPestana Apr 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
17. Teacher Notification - fix sniffer issue
  • Loading branch information
@JuanchoPestana
JuanchoPestana committed Apr 24, 2020
commit ff62493397c32f482e3f8d7448dcdc50c541f55d
2 changes: 1 addition & 1 deletion includes/class-sensei-teacher.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -882,7 +882,7 @@ public function notify_admin_teacher_course_creation( $new_status, $old_status,

$course_id = $post->ID;

if ( 'publish' == $old_status || 'private' == $old_status || 'course' != get_post_type( $course_id ) || 'auto-draft' == get_post_status( $course_id )
if ( 'publish' == $old_status || 'private' === $old_status || 'course' != get_post_type( $course_id ) || 'auto-draft' == get_post_status( $course_id )
|| 'trash' == get_post_status( $course_id ) || 'draft' == get_post_status( $course_id ) ) {

return false;
Expand Down