Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix position of the lesson status text #7742

Closed
wants to merge 1 commit into from

Conversation

merkushin
Copy link
Member

@merkushin merkushin commented Jan 24, 2025

Resolves Automattic/themes#7616

This is the minimalistic solution that addresses the problem.
In different themes, font-size & line-height are different.

Because we position the status div absolutely, its size matters.

In this PR we only fix the line-height. I have an alternative PR that addresses the issue a bit differently: #7743

Course Theme, blue and dark variations before:
line-height before blue
line-height before dark

Course Theme, blue and dark variations after:
line-height after blue
line-height after dark

Proposed Changes

  • Fix line-height for lesson status container

Testing Instructions

  1. Install and activate Course theme.
  2. Go to Site Editor and choose, Blue or Dark variation. In these two the issue is more noticeable.
  3. Stay on trunk.
  4. Go to Sensei LMS → Courses and create a course with a few lessons. Don't publish it. In this case, you have either Unsaved or Draft status for the lessons. If you publish the course, make sure you disabled publishing of the lessons.
  5. Check the position of the status in the Course Outline in the editor.
  6. Switch to this branch fix-course-outline-lesson-status-position.
  7. Refresh the editor.
  8. Make sure there is more space between the lesson title and the status.

New/Updated Hooks

Deprecated Code

Pre-Merge Checklist

  • PR title and description contain sufficient detail and accurately describe the changes
  • Adheres to coding standards (PHP, JavaScript, CSS, HTML)
  • All strings are translatable (without concatenation, handles plurals)
  • Follows our naming conventions (P6rkRX-4oA-p2)
  • Hooks (p6rkRX-1uS-p2) and functions are documented
  • New UIs are responsive and use a mobile-first approach
  • Code is tested on the minimum supported PHP and WordPress versions

@merkushin merkushin added this to the 4.24.6 milestone Jan 24, 2025
@merkushin merkushin requested a review from a team January 24, 2025 04:04
@merkushin merkushin self-assigned this Jan 24, 2025
Copy link

Test the previous changes of this PR with WordPress Playground.

@merkushin
Copy link
Member Author

We chose another solution: #7743

@merkushin merkushin closed this Jan 27, 2025
@donnapep donnapep deleted the fix/course-outline-lesson-status-position branch January 27, 2025 16:39
@donnapep donnapep removed this from the 4.24.6 milestone Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: The "draft" text is too close to the lesson title in the editor on some variations
2 participants