Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rivington and Exford: Revert change which caused warnings #8644

Merged
merged 2 commits into from
Jan 29, 2025

Conversation

scruffian
Copy link
Member

@scruffian scruffian commented Jan 29, 2025

Changes proposed in this Pull Request:

Reverts a change made in #8569 which undid a change made in 156534-ghe-Automattic/wpcom-themes

Related issue(s):

Copy link
Contributor

github-actions bot commented Jan 29, 2025

Preview changes

I've detected changes to the following themes in this PR: Exford, Rivington.
You can preview these changes by following the links below:

I will update this comment with the latest preview links as you push more changes to this PR.

Note

The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions.
Child themes are dependent on their parent themes. You will have to install the parent theme as well for the preview to work correctly.

@scruffian scruffian changed the title Rivington: Revert change which caused warnings Rivington and Exford: Revert change which caused warnings Jan 29, 2025
Copy link
Contributor

@MaggieCabrera MaggieCabrera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@scruffian scruffian merged commit e971f0b into trunk Jan 29, 2025
1 check passed
@scruffian scruffian deleted the revert/156535 branch January 29, 2025 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants