Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2E: temporarily skip broken Social: Editor Features tests #98686

Closed
wants to merge 1 commit into from

Conversation

ciampo
Copy link
Contributor

@ciampo ciampo commented Jan 21, 2025

Related to #

Proposed Changes

Temporarily skip failing e2e tests

Why are these changes being made?

All calypso PRs have failing e2e tests.

Looking at the timing on TeamCity and cross-checking with the changes being made in the Jetpack repo, it seems like Automattic/jetpack#40679 could be responsible for the regression.

@manzoorwanijk @pablinos could you please investigate the failure and follow-up with a fix that re-enables the tests?

Testing Instructions

Make sure e2e tests pass

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@ciampo ciampo requested review from pablinos, manzoorwanijk and a team January 21, 2025 14:59
@matticbot matticbot added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Jan 21, 2025
@ciampo ciampo self-assigned this Jan 21, 2025
@ciampo
Copy link
Contributor Author

ciampo commented Jan 21, 2025

Edit: I see #98683 has just been opened with a potential fix

@ciampo ciampo closed this Jan 21, 2025
@manzoorwanijk
Copy link
Member

Edit: I see #98683 has just been opened with a potential fix

Yes.

@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 21, 2025
@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants