Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A4A: Add few improvements on the new product marketplace. #99091

Merged
merged 4 commits into from
Feb 6, 2025

Conversation

jkguidaven
Copy link
Contributor

@jkguidaven jkguidaven commented Jan 30, 2025

This PR implements small enhancements to the new product marketplace based on the feedback we collected.

Context: pfunGA-4Un-p2#comment-8080

Proposed Changes

Description Before After
We placed the Payments category immediately after the Brand categories to enhance the discoverability of the Payment addons. Screenshot 2025-01-30 at 7 26 57 PM Screenshot 2025-01-30 at 7 27 34 PM
We have updated the featured products to include WooPayments, Jetpack Security, and Woo Subscriptions, as this makes more sense based on popularity. Screenshot 2025-01-30 at 7 29 07 PM Screenshot 2025-01-30 at 7 29 37 PM
The product lightbox now expands the collapsible description in mobile view. Screenshot 2025-01-30 at 7 30 56 PM Screenshot 2025-01-30 at 7 30 50 PM

Why are these changes being made?

  • This is part of the UX marketplace improvement project.

Testing Instructions

  • Use the A4A live link and go to the /marketplace/products page.
  • Test the 3 items above if it is working as expected.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@jkguidaven jkguidaven self-assigned this Jan 30, 2025
@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications

To test WordPress.com changes, run install-plugin.sh $pluginSlug add/a4a/minor-improvements on your sandbox.

@matticbot
Copy link
Contributor

matticbot commented Jan 30, 2025

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~5 bytes added 📈 [gzipped])

name                               parsed_size           gzip_size
scan                                     +12 B  (+0.0%)       +0 B
plans                                    +12 B  (+0.0%)       +0 B
jetpack-social                           +12 B  (+0.0%)       +0 B
jetpack-search                           +12 B  (+0.0%)       +0 B
jetpack-connect                          +12 B  (+0.0%)       +0 B
jetpack-cloud-pricing                    +12 B  (+0.0%)       +0 B
jetpack-cloud-partner-portal             +12 B  (+0.0%)       +5 B  (+0.0%)
jetpack-cloud-manage-pricing             +12 B  (+0.0%)       +0 B
jetpack-cloud-features-comparison        +12 B  (+0.0%)       +0 B
jetpack-cloud-agency-dashboard           +12 B  (+0.0%)       +5 B  (+0.0%)
backup                                   +12 B  (+0.0%)       +0 B
a8c-for-agencies-sites                   +12 B  (+0.0%)       +0 B

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@jkguidaven jkguidaven requested a review from a team January 30, 2025 11:32
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 30, 2025
@jkguidaven jkguidaven marked this pull request as ready for review January 30, 2025 11:33
Copy link
Contributor

@tiagonoronha tiagonoronha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jkguidaven jkguidaven force-pushed the add/a4a/minor-improvements branch from 4c446f6 to 3cd1290 Compare February 6, 2025 09:37
@jkguidaven jkguidaven merged commit 0421207 into trunk Feb 6, 2025
13 checks passed
@jkguidaven jkguidaven deleted the add/a4a/minor-improvements branch February 6, 2025 09:55
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants