Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add subscribers: Remove hasTranslation check now that translation is available #99180

Merged
merged 1 commit into from
Feb 3, 2025

Conversation

allilevine
Copy link
Member

@allilevine allilevine commented Jan 31, 2025

Proposed Changes

  • Remove hasTranslation and isEnglishLocale checks.

Why are these changes being made?

  • Clean up.

Testing Instructions

  • Change to a locale other than English.
  • Go to /subscribers on a site that has newsletter categories enabled, and click to add a subscriber.
  • Choose Manual add option.
  • Toggle on categories.
  • Check that the default text in the categories field is translated.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@allilevine allilevine self-assigned this Jan 31, 2025
@allilevine allilevine marked this pull request as ready for review January 31, 2025 20:35
@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • blaze-dashboard
  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug remove/hastranslation-categories-section-check on your sandbox.

@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~88 bytes removed 📉 [gzipped])

name         parsed_size           gzip_size
subscribers       -126 B  (-0.0%)      -39 B  (-0.0%)
people            -126 B  (-0.0%)      -49 B  (-0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@allilevine allilevine merged commit 3764e7e into trunk Feb 3, 2025
15 checks passed
@allilevine allilevine deleted the remove/hastranslation-categories-section-check branch February 3, 2025 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants