-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates to design choice step copy #99235
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
This PR does not affect the size of JS and CSS bundles shipped to the user's browser. Generated by performance advisor bot at iscalypsofastyet.com. |
@fditrapani back in #99008 (comment) we decided it was ok for the price badge to say "$5 a month" instead of "$5/month". But in this PR I'm updating it to use the slash. This is for the sake of future consistency passes. We use slashes in the escape hatch modal, so it seems we should too. I originally made the switch because we already had translations for "a month", so I'm making sure this change only happens once we have the translations ready for "/month" |
Good catch. Sounds good! Thanks for updating and notifying me. |
Translation for this Pull Request has now been finished. |
Related to pdtkmj-3kX-p2#comment-6290
Fixes #99236
Proposed Changes
Create with AI
choice description in goals-first flow/month
instead ofa month
Before
After
The control path still looks like
![CleanShot 2025-02-04 at 10 19 26@2x](https://private-user-images.githubusercontent.com/1500769/409293778-1e551d72-0ad4-4ed7-a8e3-6cb8bbc58c81.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk1MTE4MTgsIm5iZiI6MTczOTUxMTUxOCwicGF0aCI6Ii8xNTAwNzY5LzQwOTI5Mzc3OC0xZTU1MWQ3Mi0wYWQ0LTRlZDctYThlMy02Y2I4YmJjNThjODEucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIxNCUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMTRUMDUzODM4WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9OWZjMWUzNGNmNGIwYWE2MGZiNzVjYTc3ODA4NjBiODJjNTU2Y2E5ZDE1ZjM1Y2E0OTkxNDk3M2M5MjVkOTNmMyZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.UcgO5jT_8yqX_jCNUFkkAof7XrZl6dQe28Hx6Nvx7SM)
Why are these changes being made?
These changes were in the original Figma. It was pointed out during the CfT that the english copy could wrap a big nicer, and in the original Figma it did.
Testing Instructions
/setup/onboarding
Next
on goals screen and observe design choice screen/setup/onboarding
Pre-merge Checklist