Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to design choice step copy #99235

Merged
merged 3 commits into from
Feb 3, 2025
Merged

Conversation

p-jackson
Copy link
Member

@p-jackson p-jackson commented Feb 3, 2025

Related to pdtkmj-3kX-p2#comment-6290
Fixes #99236

Proposed Changes

  • Adjust width of design choice button in goals-first flow
  • Update Create with AI choice description in goals-first flow
    • "quickly and easily", not "easily and quickly"
  • Update price badge to use /month instead of a month
  • Ensure copy changes only happen once translations are complete

Before

CleanShot 2025-02-04 at 10 24 27@2x

After

CleanShot 2025-02-04 at 10 17 35@2x

The control path still looks like
CleanShot 2025-02-04 at 10 19 26@2x

Why are these changes being made?

These changes were in the original Figma. It was pointed out during the CfT that the english copy could wrap a big nicer, and in the original Figma it did.

Testing Instructions

  • Assign yourself to a treatment group in goals-first and big sky experiments
    • /setup/onboarding
    • Click Next on goals screen and observe design choice screen
  • Assign yourself to control goals-first experiment
    • /setup/onboarding
    • Remember to choose a paid plan
    • Click next till you get to the design choice screen

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@p-jackson p-jackson self-assigned this Feb 3, 2025
@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/tweaks-to-choice-screen on your sandbox.

@p-jackson p-jackson requested a review from a team February 3, 2025 21:36
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Feb 3, 2025
@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@p-jackson
Copy link
Member Author

@fditrapani back in #99008 (comment) we decided it was ok for the price badge to say "$5 a month" instead of "$5/month". But in this PR I'm updating it to use the slash.

This is for the sake of future consistency passes. We use slashes in the escape hatch modal, so it seems we should too.
CleanShot 2025-02-04 at 10 37 56@2x

I originally made the switch because we already had translations for "a month", so I'm making sure this change only happens once we have the translations ready for "/month"

@p-jackson p-jackson merged commit 18e9295 into trunk Feb 3, 2025
18 checks passed
@p-jackson p-jackson deleted the update/tweaks-to-choice-screen branch February 3, 2025 22:03
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Feb 3, 2025
@fditrapani
Copy link
Contributor

Good catch. Sounds good! Thanks for updating and notifying me.

@a8ci18n
Copy link

a8ci18n commented Feb 4, 2025

Translation for this Pull Request has now been finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Task: CfT feedback - Improve wrapping of text in design choice screen
5 participants