i18n: Update several cases of formattedNumber usage with numberFormat

[chriskmnds]

Part of addressing https://github.com/Automattic/i18n-issues/issues/934
Fixes Automattic/i18n-issues#920

Proposed Changes

• Updates several imports of formattedNumber from @automattic/components to replace with numberFormat
• Fixes the wrong/missing translations resulting from not using numberFormat with the correct locale

Some notes below: #99273 (comment)

Why are these changes being made?

Part of addressing https://github.com/Automattic/i18n-issues/issues/934
Fixes Automattic/i18n-issues#920

Testing Instructions

• Code review
• All of these cases should be checked, but a few should also suffice. They are all handled similarly.

/stats/insights/:site - All-time Highlights section

Before (EL)

After (EL)

Pre-merge Checklist

• Has the general commit checklist been followed? (PCYsg-hS-p2)
• Have you written new tests for your changes?
• Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
• Have you checked for TypeScript, React or other console errors?
• Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
• Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
• For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

[github-actions]

Calypso Live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-132278

Jetpack Cloud live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-132278&env=jetpack

Automattic for Agencies live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-132278&env=a8c-for-agencies

[matticbot]

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~294 bytes removed 📉 [gzipped])

name   parsed_size           gzip_size
stats       -923 B  (-0.1%)     -294 B  (-0.1%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~23 bytes removed 📉 [gzipped])

name                                              parsed_size           gzip_size
async-load-calypso-my-sites-stats-pages-insights        -73 B  (-0.1%)      -23 B  (-0.1%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

[matticbot]

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

• notifications
• odyssey-stats
• wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/i18n-number-format-replace-formattedNumber on your sandbox.

[chriskmnds]

This is interesting.formattedNumber is a little tricky and easy to ignore what it does underneath. It passes an empty object {} to formatNumber method, forcing it to not use the DEFAULT_OPTIONS constant (which defines a "compact" number formatting). So using formattedNumber by default results in "standard" notation, while using formatNumber by default results in "compact" notation. Took me a few rounds to spot. 😵

Almost introduced a bit of bugging into the UI. Should be ok now.