Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Purchase Settings: Update manage-purchase__header styles for better wrapping #99319

Merged
merged 3 commits into from
Feb 7, 2025

Conversation

jjchrisdiehl
Copy link
Contributor

The Purchase Settings section doesn't handle text wrapping correctly in both the header and content components:

320px 425px 870px
image image image

I also noticed that the manage-purchase__renew-upgrade-buttons are set to display: none on smaller devices and...I'm not sure why.

So along with the refactor of the header I also moved the renewal/upgrade buttons into the header section and added styling so they adjust their position across device sizes:

< 480px < 660px Desktop
image image image

All units have been converted to their relative counterparts, i.e margin-inline-start or flex-start/end so this should remain responsive for LTR languages too.

Related to #98958

Testing Instructions

  • Go to Purchases and select a purchase to open its Purchase Settings - its best to try a product with a long string of text, like a very long domain name (but try a number of products to hedge against any regressions)
  • From there, open dev tools and adjust the window width to test out the new flexibility of the text and buttons
  • Try a LTR language, it should behave similarly
  • There shouldn't be any horizontal or vertical scrolling or clipping in the manage-purchase__header or manage-purchase__content sections

@jjchrisdiehl jjchrisdiehl added the [Feature] Purchase Management Related to managing purchases such as subscriptions, plans, history, auto-renew, cancellation, etc. label Feb 5, 2025
@jjchrisdiehl jjchrisdiehl requested a review from a team as a code owner February 5, 2025 05:21
@matticbot matticbot added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Feb 5, 2025
@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~4 bytes added 📈 [gzipped])

name            parsed_size           gzip_size
site-purchases        +44 B  (+0.0%)       +4 B  (+0.0%)
purchases             +44 B  (+0.0%)       +4 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Member

@sirbrillig sirbrillig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jjchrisdiehl jjchrisdiehl merged commit 987e8f6 into trunk Feb 7, 2025
16 of 17 checks passed
@jjchrisdiehl jjchrisdiehl deleted the fix/word-wrap-purchase-settings branch February 7, 2025 21:34
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Purchase Management Related to managing purchases such as subscriptions, plans, history, auto-renew, cancellation, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants