-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stats: adds replacement subscribers chart #99332
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Async-loaded Components (~192 bytes added 📈 [gzipped])
React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
85051a1
to
10a731c
Compare
client/my-sites/stats/stats-subscribers-chart-section/index.tsx
Outdated
Show resolved
Hide resolved
{ | ||
label: 'Subscribers', | ||
options: { | ||
stroke: '#069e08', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should have use different color for Calypso
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup absolutely. On my current PR list to add a Calypso color theme to the chart library, which we can use webpack in Odyssey to replace it with the Jetpack theme.
data: data?.data?.map( ( point ) => ( { | ||
date: new Date( point.period ), | ||
value: point.subscribers || 0, | ||
} ) ) || [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy to keep the dummy data for now, but let's remove it before going live
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep totally 👍 This is just a small chunk of a PR to put the chart component in. Will definitely replace the dummy data in one of my followup PRs. Just making an adjustment to the component structure to handle both realtime (as currently) data and static/periodic data.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
10a731c
to
03f9001
Compare
Related to #
Proposed Changes
Testing Instructions
/stats/subscribers/{URL}i?flags=stats/chart-library
flags=stats/chart-library
Pre-merge Checklist