Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align all domain overview pages to center (except upsells) #99377

Merged
merged 1 commit into from
Feb 6, 2025

Conversation

Imran92
Copy link
Contributor

@Imran92 Imran92 commented Feb 5, 2025

Related to #99294

Proposed Changes

  • Align all domain overview and email pages and sub-pages to left. Except the email upsell and email plan comparison pages
  • Make the max width 1040px.
  • We left the upsell and plan comparison pages center aligned because they don't look good when left-aligned

Why are these changes being made?

  • To fix alignment problems

Testing Instructions

  • Go to /domains/manage
  • Open a domain in flyout by clicking on the title of the domain
  • Go through all domain main pages and sub pages
  • Make sure all of them align to the left (except for the email upsell and plan comparison pages) and max-width always remains as expected

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@Imran92 Imran92 requested a review from a team February 5, 2025 22:28
@Imran92 Imran92 self-assigned this Feb 5, 2025
@Imran92 Imran92 requested a review from a team as a code owner February 5, 2025 22:28
@matticbot matticbot added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Feb 5, 2025
@Imran92 Imran92 linked an issue Feb 5, 2025 that may be closed by this pull request
@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~15 bytes added 📈 [gzipped])

name     parsed_size           gzip_size
hosting        +85 B  (+0.0%)      +15 B  (+0.0%)
email          +85 B  (+0.0%)      +15 B  (+0.0%)
domains        +85 B  (+0.0%)      +15 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Member

@m1r0 m1r0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The alignment and max-width work as described. 👍

@Imran92 Imran92 merged commit 27284c6 into trunk Feb 6, 2025
17 checks passed
@Imran92 Imran92 deleted the fix/alignment-and-width-of-email-pages branch February 6, 2025 13:23
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CFT-Untangling: Fix max width and left alignment of all page contents
3 participants