Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deps: Use sass-loader v13 #99412

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from
Open

Deps: Use sass-loader v13 #99412

wants to merge 1 commit into from

Conversation

tyxla
Copy link
Member

@tyxla tyxla commented Feb 6, 2025

Proposed Changes

Consistently use sass-loader@13 instead of 3 different versions.

Why are these changes being made?

During the latest WordPress monorepo upgrade (#96470) I noticed this inconsistency and thought it might make sense to be fixed.

Testing Instructions

  • Build should work well and all checks should be green.
  • Do some smoke testing and verify things work well.

@tyxla tyxla self-assigned this Feb 6, 2025
@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • help-center
  • notifications
  • odyssey-stats
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/sass-loader-13 on your sandbox.

@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@tyxla tyxla force-pushed the update/sass-loader-13 branch from 31123c9 to 41be4eb Compare February 13, 2025 13:10
@tyxla tyxla added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. dependencies Pull requests that update a dependency file labels Feb 13, 2025
@tyxla tyxla requested a review from a team February 13, 2025 13:12
@tyxla tyxla marked this pull request as ready for review February 13, 2025 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants