Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds the site's goals to the launchpad tracks events #99464

Merged
merged 1 commit into from
Feb 9, 2025

Conversation

p-jackson
Copy link
Member

@p-jackson p-jackson commented Feb 7, 2025

Related to #98623

Proposed Changes

  • Add goals prop to _task_view, _tasklist_viewed, and _task_clicked launchpad tracks events
  • Stringifies the goals list using commas, just like we do in the goals screen tracks events

Why are these changes being made?

This makes the performance of goals and tasks easier for the data team to analyse.

p1738900386353329/1738879562.278169-slack-C04H4NY6STW

Testing Instructions

  • Create new sites with various goal combinations
    • Use a goal selection that lands in My Home (like Newsletter)
    • Use a goal selection that lands in the fullscreen launchpad
    • Use an empty goals selection
  • Confirm the _tasklist_viewed, _task_view, and _task_clicked events are sent with goals props

Note that the "task completed" event is recorded on the backend, so not part of this PR.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@p-jackson p-jackson self-assigned this Feb 7, 2025
@p-jackson p-jackson requested a review from a team February 7, 2025 09:02
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Feb 7, 2025
@p-jackson p-jackson added Reviewer Can Merge PR author indicates the reviewer is free to merge/deploy if they want to own the change. [Feature] Launchpad The onboarding Launchpad that guides users through setting up their site and getting it launched. and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Feb 7, 2025
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Feb 7, 2025
@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • odyssey-stats
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug add/goals-prop-launchpad-tracks on your sandbox.

@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~87 bytes added 📈 [gzipped])

name                           parsed_size           gzip_size
write-flow                           +60 B  (+0.0%)      +12 B  (+0.0%)
transferring-hosted-site-flow        +60 B  (+0.0%)      +22 B  (+0.0%)
subscribers                          +60 B  (+0.0%)      +20 B  (+0.0%)
link-in-bio-tld-flow                 +60 B  (+0.0%)      +12 B  (+0.0%)
home                                 +60 B  (+0.0%)      +15 B  (+0.0%)
earn                                 +60 B  (+0.0%)      +18 B  (+0.0%)
build-flow                           +60 B  (+0.0%)      +12 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~20 bytes added 📈 [gzipped])

name                                                 parsed_size           gzip_size
async-load-calypso-my-sites-stats-pages-subscribers        +60 B  (+0.0%)      +20 B  (+0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Contributor

@vykes-mac vykes-mac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@p-jackson p-jackson merged commit 82714f0 into trunk Feb 9, 2025
17 of 18 checks passed
@p-jackson p-jackson deleted the add/goals-prop-launchpad-tracks branch February 9, 2025 21:10
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Feb 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Launchpad The onboarding Launchpad that guides users through setting up their site and getting it launched. Reviewer Can Merge PR author indicates the reviewer is free to merge/deploy if they want to own the change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants