Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release focused launchpad to wpcalypso - with tests fix #99480

Conversation

paulopmt1
Copy link
Contributor

Context: p1738781315185299/1737519094.618889-slack-C04H4NY6STW
PT: pet6gk-1T7-p2

Proposed Changes

We want to allow designers to test the Focused Launchpad in My home on wpcalypso so they can test the whole flow with the proper redirects it does

Why are these changes being made?

Just adding the ?flags=home/launchpad-first doesn't allow us testing everything because /site-creating/processing removes it and the /home redirect also removes it redirecting the user back to /build/launchpad instead of keeping them at the focused launchpad.

Testing Instructions

  • Just ensure we're editing the correct file to release the changes to wpcalypso, instead of staging or even prod.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@paulopmt1 paulopmt1 changed the title Release focused launchpad to wpcalypso Release focused launchpad to wpcalypso - with testx fix Feb 7, 2025
@paulopmt1 paulopmt1 changed the title Release focused launchpad to wpcalypso - with testx fix Release focused launchpad to wpcalypso - with tests fix Feb 7, 2025
@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug revert-99373-revert-99370-update/release-launchpad-first-on-wpcalypso on your sandbox.

@paulopmt1 paulopmt1 force-pushed the revert-99373-revert-99370-update/release-launchpad-first-on-wpcalypso branch from 5e5938e to d6f22e6 Compare February 7, 2025 14:37
@paulopmt1
Copy link
Contributor Author

This was already approved here: #99370

@paulopmt1
Copy link
Contributor Author

Pre-release tests passed here on TeamCity.

@paulopmt1 paulopmt1 linked an issue Feb 7, 2025 that may be closed by this pull request
1 task
@paulopmt1 paulopmt1 merged commit d8472c6 into trunk Feb 7, 2025
13 checks passed
@paulopmt1 paulopmt1 deleted the revert-99373-revert-99370-update/release-launchpad-first-on-wpcalypso branch February 7, 2025 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Task: Release Focused in My Home on wpcalypso
2 participants