-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stats: Unify title processing for different Post cards #99481
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Async-loaded Components (~132 bytes added 📈 [gzipped])
React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the refactor. LGTM!
Proposed Changes
Updates the two Post cards on the Insights page to use the improved processing as introduced on the Post Detail page. Includes a small refactoring to put the shared functions into a separate
text-utils/index.tsx
file and updates theLatestPostCard
andPostCardsGroup
components to use them.Before
After
Why are these changes being made?
The previous logic would cut titles mid-word. The new truncation logic attempts to truncate on whitespace if possible. It also processes HTML tags & entities before truncation so as to avoid truncating mid tag/entity.
Testing Instructions
Pre-merge Checklist