Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stats: Unify title processing for different Post cards #99481

Merged
merged 8 commits into from
Feb 9, 2025

Conversation

a8ck3n
Copy link
Contributor

@a8ck3n a8ck3n commented Feb 7, 2025

Proposed Changes

Updates the two Post cards on the Insights page to use the improved processing as introduced on the Post Detail page. Includes a small refactoring to put the shared functions into a separate text-utils/index.tsx file and updates the LatestPostCard and PostCardsGroup components to use them.

Before

SCR-20250207-snch

After

SCR-20250207-smyf

Why are these changes being made?

The previous logic would cut titles mid-word. The new truncation logic attempts to truncate on whitespace if possible. It also processes HTML tags & entities before truncation so as to avoid truncating mid tag/entity.

Testing Instructions

  • Launch the Calypso Live link.
  • Visit Stats → Insights.
  • Confirm the title is truncated on whitespace.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • odyssey-stats

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/stats-shared-title-processing on your sandbox.

@a8ck3n a8ck3n self-assigned this Feb 7, 2025
@a8ck3n a8ck3n added the [Feature] Stats Everything related to our analytics product at /stats/ label Feb 7, 2025
@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Async-loaded Components (~132 bytes added 📈 [gzipped])

name                                                 parsed_size           gzip_size
async-load-calypso-my-sites-stats-stats-post-detail       +243 B  (+0.7%)      +47 B  (+0.5%)
async-load-calypso-my-sites-stats-pages-insights          +143 B  (+0.3%)      +85 B  (+0.5%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@a8ck3n a8ck3n marked this pull request as ready for review February 7, 2025 13:26
@a8ck3n a8ck3n requested a review from a team February 7, 2025 13:27
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Feb 7, 2025
Copy link
Contributor

@dognose24 dognose24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the refactor. LGTM!

@kangzj kangzj merged commit d545a5e into trunk Feb 9, 2025
18 checks passed
@kangzj kangzj deleted the update/stats-shared-title-processing branch February 9, 2025 19:58
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Feb 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Stats Everything related to our analytics product at /stats/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants