Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Site Admin]: introduce <SiteIcon /> component #99540

Merged
merged 28 commits into from
Feb 12, 2025
Merged

[Site Admin]: introduce <SiteIcon /> component #99540

Changes from 1 commit
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
63dc249
introduce SiteIcon component
retrofox Feb 7, 2025
795fa4d
add storybook pkgs dependencies
retrofox Feb 7, 2025
296553e
Support storybook for this package
retrofox Feb 7, 2025
7f2f6b1
add package dependencies
retrofox Feb 11, 2025
f28ff49
add Woo logo to the public storybook folder
retrofox Feb 10, 2025
9f6b9dd
set public/ as storybook public folder
retrofox Feb 10, 2025
bd60034
basic core data store mock for storybook
retrofox Feb 10, 2025
c0b8052
minor jsdoc change
retrofox Feb 10, 2025
ff05f0d
add site-icon story
retrofox Feb 10, 2025
d98e685
clean unused impoerted libs
retrofox Feb 10, 2025
33270a5
Add missing @storybook/addon-toolbars addon
tyxla Feb 10, 2025
73da979
rename/add public images to storybook
retrofox Feb 10, 2025
8a7018f
add regular and jetpack testing sites
retrofox Feb 10, 2025
6d4e206
populate mock stories registry
retrofox Feb 10, 2025
b34a2c7
type SiteIcon story args
retrofox Feb 11, 2025
2cde4a7
add @example to SiteIcon component
retrofox Feb 11, 2025
e607604
makestory site titles more friendly
retrofox Feb 11, 2025
e907a14
expose SiteIcon component
retrofox Feb 11, 2025
c81cecc
Update packages/site-admin/package.json
retrofox Feb 12, 2025
924d0f4
do not export SiteIcon component
retrofox Feb 12, 2025
4325c0b
do not export the component by defaull. Add jsdoc
retrofox Feb 12, 2025
1378cee
do not overwrite styles by using component class
retrofox Feb 12, 2025
1d89cd3
use CSF3 format to define story component
retrofox Feb 12, 2025
e9bc9a5
add a todo about reorganizing styles in follow-ups
retrofox Feb 12, 2025
a6f7a8c
replace Site selector icon with `home`
retrofox Feb 12, 2025
f1d4939
The description should end with a period
retrofox Feb 12, 2025
4064780
Update packages/site-admin/src/components/site-icon/index.tsx
retrofox Feb 12, 2025
c0d637e
remove unused __() lib
retrofox Feb 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
replace Site selector icon with home
  • Loading branch information
@retrofox
retrofox committed Feb 12, 2025
commit a6f7a8c2a2bd6a010fcfd9372f5467549688c4ab
2 changes: 1 addition & 1 deletion packages/site-admin/.storybook/preview.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ export const globalTypes = {
description: 'Site for testing',
defaultValue: siteKeys[ 0 ],
toolbar: {
icon: 'globe',
icon: 'home',
items: siteKeys,
},
},
Expand Down