Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n: Add TypeScript configuration/build to i18n-calypso #99590

Merged
merged 6 commits into from
Feb 13, 2025

Conversation

chriskmnds
Copy link
Contributor

@chriskmnds chriskmnds commented Feb 11, 2025

Part of addressing https://github.com/Automattic/i18n-issues/issues/940 (and others)

Proposed Changes

  • Adds TS configuration presets to i18n-calypso so it can be built as a TS package
  • Does not refactor any actual code to TS, except for some minimal file renames
  • Updates dependencies and some references to the previous types file

Why are these changes being made?

Testing Instructions

  • No functional changes.
  • The package should now have a /dist folder with the respective cjs, esm, and types folders.
  • Exported types can now be retrieved directly from i18n-calypso.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • blaze-dashboard
  • command-palette-wp-admin
  • happy-blocks
  • help-center
  • notifications
  • odyssey-stats
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/i18n-calypso-ts-build on your sandbox.

@chriskmnds chriskmnds marked this pull request as ready for review February 11, 2025 15:03
@chriskmnds chriskmnds requested a review from a team as a code owner February 11, 2025 15:03
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Feb 11, 2025
@chriskmnds chriskmnds changed the title i18n: Add TypeScript presets/configuration to i18n-calypso i18n: Add TypeScript configuration/build to i18n-calypso Feb 12, 2025
@chriskmnds
Copy link
Contributor Author

Merging this. What could go wrong? 🙄

@chriskmnds chriskmnds merged commit 6ae1598 into trunk Feb 13, 2025
14 checks passed
@chriskmnds chriskmnds deleted the update/i18n-calypso-ts-build branch February 13, 2025 15:57
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants