Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SelectableTextBlock selection #18049

Merged
merged 1 commit into from
Feb 3, 2025
Merged

Conversation

love-linger
Copy link
Contributor

What does the pull request do?

Makes SelectableTextBlock.SelectAll method to support inlines.

What is the current behavior?

Triple click on SelectableTextBlock with inlines does not select all text.

What is the updated/expected behavior with this PR?

Triple click on SelectableTextBlock with inlines will select all text.

How was the solution implemented (if it's not obvious)?

Checklist

Breaking changes

Obsoletions / Deprecations

Fixed issues

@avaloniaui-bot
Copy link

You can test this PR using the following package version. 11.3.999-cibuild0054552-alpha. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@cla-avalonia
Copy link
Collaborator

cla-avalonia commented Jan 25, 2025

  • All contributors have signed the CLA.

@love-linger
Copy link
Contributor Author

@cla-avalonia agree

@MrJul MrJul added the bug label Feb 2, 2025
@MrJul MrJul requested a review from Gillibald February 2, 2025 14:34
Copy link
Contributor

@Gillibald Gillibald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Gillibald Gillibald added this pull request to the merge queue Feb 3, 2025
@Gillibald Gillibald added the backport-candidate-11.2.x Consider this PR for backporting to 11.2 branch label Feb 3, 2025
Merged via the queue into AvaloniaUI:master with commit eafb41d Feb 3, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-candidate-11.2.x Consider this PR for backporting to 11.2 branch bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants