Merge branch 'master' of github.com:huacnlee/social-share-button

Awadhesh31 · Oct 5, 2016 · 8951520 · 8951520
2 parents e73cc0f + 6077bef
commit 8951520
Show file tree

Hide file tree

Showing 10 changed files with 81 additions and 2 deletions.
diff --git a/README.md b/README.md
@@ -22,6 +22,7 @@ This is a gem to helper you quick create a share feature in you Rails apps.
 * Vkontakte
 * Xing
 * Reddit
+* Hacker News (Y Combinator)
 
 ## Screenshot
 

diff --git a/app/assets/images/social-share-button/hacker_news.svg b/app/assets/images/social-share-button/hacker_news.svg
diff --git a/app/assets/javascripts/social-share-button.coffee b/app/assets/javascripts/social-share-button.coffee
@@ -85,4 +85,6 @@ window.SocialShareButton =
 
       when "reddit"
         SocialShareButton.openUrl("http://www.reddit.com/submit?url=#{url}&newwindow=1", 555, 400)
+      when "hacker_news"
+        SocialShareButton.openUrl("http://news.ycombinator.com/submitlink?u=#{url}&t=#{title}", 770, 500)
     false
diff --git a/app/assets/stylesheets/social-share-button.scss b/app/assets/stylesheets/social-share-button.scss
@@ -11,7 +11,8 @@ $size: 18px;
   }
 
   @each $site in twitter, facebook, google_bookmark, google_plus, weibo, qq,
-                 delicious, linkedin, tumblr, pinterest, douban, wechat, vkontakte, xing, email, reddit {
+                 delicious, linkedin, tumblr, pinterest, douban, wechat, vkontakte,
+                 xing, email, reddit, hacker_news {
     .ssb-#{$site} {
       background-image: image-url('social-share-button/#{$site}.svg');
     }

diff --git a/lib/generators/social_share_button/templates/config/initializers/social_share_button.rb b/lib/generators/social_share_button/templates/config/initializers/social_share_button.rb
@@ -1,3 +1,3 @@
 SocialShareButton.configure do |config|
-  config.allow_sites = %w(twitter facebook google_plus weibo qq douban google_bookmark delicious tumblr pinterest email linkedin wechat vkontakte xing)
+  config.allow_sites = %w(twitter facebook google_plus weibo qq douban google_bookmark delicious tumblr pinterest email linkedin wechat vkontakte xing reddit hacker_news)
 end
diff --git a/lib/generators/social_share_button/templates/config/locales/social_share_button.en.yml b/lib/generators/social_share_button/templates/config/locales/social_share_button.en.yml
@@ -18,3 +18,4 @@ en:
     vkontakte: Vkontakte
     xing: Xing
     reddit: Reddit
+    hacker_news: Hacker News
diff --git a/lib/generators/social_share_button/templates/config/locales/social_share_button.fr.yml b/lib/generators/social_share_button/templates/config/locales/social_share_button.fr.yml
@@ -18,3 +18,4 @@ fr:
     vkontakte: Vkontakte
     xing: Xing
     reddit: Reddit
+    hacker_news: Hacker News
diff --git a/lib/generators/social_share_button/templates/config/locales/social_share_button.zh-CN.yml b/lib/generators/social_share_button/templates/config/locales/social_share_button.zh-CN.yml
@@ -18,3 +18,4 @@
     vkontakte: Vkontakte
     xing: Xing
     reddit: Reddit
+    hacker_news: Hacker News
diff --git a/lib/generators/social_share_button/templates/config/locales/social_share_button.zh-TW.yml b/lib/generators/social_share_button/templates/config/locales/social_share_button.zh-TW.yml
@@ -18,3 +18,4 @@
     vkontakte: Vkontakte
     xing: Xing
     reddit: Reddit
+    hacker_news: Hacker News
diff --git a/lib/social_share_button/config.rb b/lib/social_share_button/config.rb
@@ -23,7 +23,9 @@ class Config
     # - linkedin
     # - wechat
     # - vkontakte
+    # - Xing
     # - reddit
+    # - hacker_news
     attr_accessor :allow_sites
 
     def initialize