- Added CodeDomEvaluator.CscTimeout to allow auto-termination of th…

…e `csc.exe` when it hangs. Triggered by oleg-shilo#318
AzizDZH · Feb 25, 2023 · a375579 · a375579
1 parent a39fe31
commit a375579
Showing 1 changed file with 16 additions and 2 deletions.
diff --git a/src/CSScriptLib/src/CSScriptLib/Evaluator.CodeDom.cs b/src/CSScriptLib/src/CSScriptLib/Evaluator.CodeDom.cs
@@ -57,6 +57,20 @@ public class CodeDomEvaluator : EvaluatorBase<CodeDomEvaluator>, IEvaluator
         /// </summary>
         public static bool CompileOnServer = true;
 
+        /// <summary>
+        /// Timeout for the C# CLI compiler `csc.exe`.
+        /// <para>
+        /// This compiler is a part of .NET SDK and it is the actual
+        /// tool that compiles C# code into assembly when CodeDomEvaluator is used.
+        /// This tool under certain circumstances has tendency to hang after even if it successfully
+        /// finished the compilation. Thus configurable timeout allows user to configure forcible termination
+        /// of the csc.exe process.
+        /// </para>
+        /// <para>
+        /// The default value is -1 (infinite).</para>
+        /// </summary>
+        public static int CscTimeout = -1;
+
         /// <summary>
         /// The low level output of the last script compilation. This member is not designed to be a
         /// part of script error handling. For this purpose a normal exception based mechanism the
@@ -302,7 +316,7 @@ bool buildServerNotRunning() => response.GetLines()
                     {
                         cmd = $@"""{Globals.csc}"" {common_args.JoinBy(" ")} /out:""{assembly}"" {refs_args.JoinBy(" ")} {source_args.JoinBy(" ")}";
 
-                        result.NativeCompilerReturnValue = dotnet.Run(cmd, build_dir, x => result.Output.Add(x), x => std_err += x);
+                        result.NativeCompilerReturnValue = dotnet.Run(cmd, build_dir, x => result.Output.Add(x), x => std_err += x, CodeDomEvaluator.CscTimeout);
                     }
                 }
                 else
@@ -311,7 +325,7 @@ bool buildServerNotRunning() => response.GetLines()
 
                     try
                     {
-                        result.NativeCompilerReturnValue = Globals.csc.Run(cmd, build_dir, x => result.Output.Add(x), x => std_err += x);
+                        result.NativeCompilerReturnValue = Globals.csc.Run(cmd, build_dir, x => result.Output.Add(x), x => std_err += x, CodeDomEvaluator.CscTimeout);
                     }
                     catch (Exception e)
                     {