Skip to content

Commit

Permalink
Pass backendErr to emitMetrics
Browse files Browse the repository at this point in the history
nil was mistakenly being passed to emitMetrics, causing resultType to always fail collection due to the nil backendError provided.
  • Loading branch information
s-fairchild committed Nov 8, 2024
1 parent a73f541 commit 879258e
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions pkg/backend/openshiftcluster.go
Original file line number Diff line number Diff line change
Expand Up @@ -311,7 +311,7 @@ func (ocb *openShiftClusterBackend) endLease(ctx context.Context, log *logrus.En
return err
}
ocb.asyncOperationResultLog(log, initialProvisioningState, backendErr)
ocb.emitMetrics(log, doc, operationType, provisioningState, nil)
ocb.emitMetrics(log, doc, operationType, provisioningState, backendErr)
ocb.emitProvisioningMetrics(doc, provisioningState)
}

Expand All @@ -330,7 +330,7 @@ func (ocb *openShiftClusterBackend) endLease(ctx context.Context, log *logrus.En
stop()
}

ocb.emitMetrics(log, doc, operationType, provisioningState, nil)
ocb.emitMetrics(log, doc, operationType, provisioningState, backendErr)
return err
}

Expand Down

0 comments on commit 879258e

Please sign in to comment.