-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] - Migrate to azuresdk/armnetwork in pkg/cluster/delete.go #4073
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Regarding testing, besides e2e, is there any other caveats to be considered?
@bdematte please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
Which issue this PR addresses:
Implements https://issues.redhat.com/browse/ARO-12544
What this PR does / why we need it:
Partial implementation of the migration from mgmt/network to azuresdk/armnetwork (focused on pkg/cluster/delete.go)
Test plan for issue:
Technical migration, e2e covering it
Is there any documentation that needs to be updated for this PR?
No
How do you know this will function as expected in production?
Technical migration.