Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[connectedk8s] Update extension CLI to v1.10.7 #8531

Merged
merged 53 commits into from
Mar 7, 2025

Conversation

atchutbarli
Copy link
Contributor


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az connectedk8s

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Sorry, something went wrong.

Bavneet Singh and others added 30 commits November 22, 2024 09:02

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
* ruff fix

* remove duplicate code block

* cleaner fix for no existing kubeconfig

makes the type annotations true again

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
…p_migration

Add AT refresh for Proxy

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Add Kubectl Check to Proxy Test

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
…rror

add telemetry for helm install error
bavneetsingh16 and others added 7 commits February 14, 2025 11:09

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
update connectedk8s cli version and release notes - v1.10.6

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
#35)

* add distros

* format

* ruffcheck

* ruffformat

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
* add prereq

* standard

* format

* typo

* brackets

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
* add release history

* whl test

* remove whl

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Copy link

azure-client-tools-bot-prd bot commented Mar 6, 2025

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

@yonzhan
Copy link
Collaborator

yonzhan commented Mar 6, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

Copy link

github-actions bot commented Mar 6, 2025

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

@atchutbarli
Copy link
Contributor Author

We have set up live tests in our forked repository as a continuous integration (CI) check and those tests include coverage for all these changes. All the tests can be found here:
https://github.com/AzureArcForKubernetes/connectedk8s/blob/main/testing/test/configurations

As the code owners of this extension CLI, we mandate that all changes be first made in our forked repository to ensure they undergo our comprehensive test suite

Copy link

github-actions bot commented Mar 6, 2025

@atchutbarli atchutbarli marked this pull request as draft March 6, 2025 22:50
JorgeDaboub and others added 2 commits March 6, 2025 17:05

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@atchutbarli atchutbarli marked this pull request as ready for review March 7, 2025 02:37
@zhoxing-ms
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@zhoxing-ms zhoxing-ms merged commit 14445e5 into Azure:main Mar 7, 2025
21 of 22 checks passed
@azclibot
Copy link
Collaborator

azclibot commented Mar 7, 2025

[Release] Update index.json for extension [ connectedk8s-1.10.7 ] : https://dev.azure.com/msazure/One/_build/results?buildId=117223076&view=results

@@ -146,8 +146,7 @@ def fetch_and_post_at_to_csp(
profile = Profile(cli_ctx=cmd.cli_ctx)
try:
credential, _, _ = profile.get_login_credentials(
subscription_id=profile.get_subscription()["id"],
resource=consts.KAP_1P_Server_App_Scope,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Track 1 Azure Python SDK support has been dropped in Azure CLI 2.70.0 (Azure/azure-cli#30951).

Azure/azure-cli#30951 explains why resource parameter should not be passed to Profile.get_login_credentials().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants