-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[connectedk8s] Update extension CLI to v1.10.7 #8531
Conversation
* ruff fix * remove duplicate code block * cleaner fix for no existing kubeconfig makes the type annotations true again
…ForKubernetes/connectedk8s into atchub/helminstallerror
…p_migration Add AT refresh for Proxy
Add Kubectl Check to Proxy Test
…ForKubernetes/connectedk8s into atchub/helminstallerror
…rror add telemetry for helm install error
update connectedk8s cli version and release notes - v1.10.6
#35) * add distros * format * ruffcheck * ruffformat
* add prereq * standard * format * typo * brackets
* add release history * whl test * remove whl
️✔️Azure CLI Extensions Breaking Change Test
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
We have set up live tests in our forked repository as a continuous integration (CI) check and those tests include coverage for all these changes. All the tests can be found here: As the code owners of this extension CLI, we mandate that all changes be first made in our forked repository to ensure they undergo our comprehensive test suite |
|
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
[Release] Update index.json for extension [ connectedk8s-1.10.7 ] : https://dev.azure.com/msazure/One/_build/results?buildId=117223076&view=results |
@@ -146,8 +146,7 @@ def fetch_and_post_at_to_csp( | |||
profile = Profile(cli_ctx=cmd.cli_ctx) | |||
try: | |||
credential, _, _ = profile.get_login_credentials( | |||
subscription_id=profile.get_subscription()["id"], | |||
resource=consts.KAP_1P_Server_App_Scope, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Track 1 Azure Python SDK support has been dropped in Azure CLI 2.70.0 (Azure/azure-cli#30951).
Azure/azure-cli#30951 explains why resource
parameter should not be passed to Profile.get_login_credentials()
.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
az connectedk8s
General Guidelines
azdev style <YOUR_EXT>
locally? (pip install azdev
required)python scripts/ci/test_index.py -q
locally? (pip install wheel==0.30.0
required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.json
automatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json
.