Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DurableOrchestrationStatus to reference correct history data key from init argument #621

Open
wants to merge 3 commits into
base: v3.x
Choose a base branch
from

Conversation

JPF3N998
Copy link

@JPF3N998 JPF3N998 commented Dec 21, 2024

Addresses #620

What's new?

According to official docs, orchestration history data is returned on the historyEvents key inside the response.

Current implementation prior to these changes are referencing the history key from the response, which doesn't exist leading to setting undefined on the DurableOrchestrationStatus's history attribute.

This PR updates the DurableORchestrationStatus's constructor to pluck the history data from the historyEvents key from the init constructor argument and also update the class attribute history name to historyEvents for consistency and match the official docs.

@JPF3N998 JPF3N998 changed the title Update DurableOrchestrationStatus to reference correct history data key from data.response Update DurableOrchestrationStatus to reference correct history data key from init argument Dec 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant