VPN Client Protocols for Virtual Network Gateways

[henry416]

+Added VPN Client Protocols for Virtual Network Gateway (SSTP, IkeV2)
+Updated network nuget packages

---

This checklist is used to make sure that common guidelines for a pull request are followed. You can find a more complete discussion of PowerShell cmdlet best practices here.

• I have read the contribution guidelines.
• If changes were made to any cmdlet, the XML help was regenerated using the platyPSHelp module.
• If any large changes are made to a service, they are reflected in the respective change log.

General Guidelines

• Title of the pull request is clear and informative.
• There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.
• The pull request does not introduce breaking changes (unless a major version change occurs in the assembly and module).

Testing Guidelines

• Pull request includes test coverage for the included changes.
• PowerShell scripts used in tests should do any necessary setup as part of the test or suite setup, and should not use hard-coded values for locations or existing resources.

Cmdlet Signature Guidelines

• New cmdlets that make changes or have side effects should implement ShouldProcess and have SupportShouldProcess=true specified in the cmdlet attribute. You can find more information on ShouldProcess here.
• Cmdlet specifies OutputType attribute if any output is produced - if the cmdlet produces no output, it should implement a PassThru parameter.

Cmdlet Parameter Guidelines

• Parameter types should not expose types from the management library - complex parameter types should be defined in the module.
• Complex parameter types are discouraged - a parameter type should be simple types as often as possible. If complex types are used, they should be shallow and easily creatable from a constructor or another cmdlet.
• Cmdlet parameter sets should be mutually exclusive - each parameter set must have at least one mandatory parameter not in other parameter sets.

[henry416]

There might be some overlap with #4265 since that PR is updating to Network 11

[cormacpayne]

@azuresdkci test this please

[henry416]

I don't understand this error that the build is giving - it works fine on local

[cormacpayne]

@henry416 try removing the forward slash at the end of this line before the closing angle bracket

[cormacpayne]

@henry416 a few comments

[cormacpayne]

@henry416 this should be a check-in test

[cormacpayne]

@henry416 this parameter should be renamed to VpnClientProtocol. From the PowerShell Strongly Encouraged Developer Guidelines:

Avoid using plural names for parameters whose value is a single element. This includes parameters that take arrays or lists because the user might supply an array or list with only one element.

Plural parameter names should be used only in those cases where the value of the parameter is always a multiple-element value. In these cases, the cmdlet should verify that multiple elements are supplied, and the cmdlet should display a warning to the user if multiple elements are not supplied.

[cormacpayne]

@henry416 same comment

[henry416]

I apologize for the delay, I am having difficulties in getting the Network solution to run tests though it was working a day ago

[cormacpayne]

Closing this PR due to lack of activity. @henry416 feel free to reopen this issue when you are able to run the tests and resolve the feedback that was left.