-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Mariner Arm64 docker image distribution. #2891
Open
dphulkar-msft
wants to merge
21
commits into
main
Choose a base branch
from
dphulkar/dockerMarinerArm64Support
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+95
−89
Open
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
e49be3e
Add support for mariner arm64
dphulkar-msft b4fbb97
Merge branch 'main' of https://github.com/Azure/azure-storage-azcopy …
dphulkar-msft bdd6665
Added template file for docker build and publish steps
dphulkar-msft 6853063
Updated the comment
dphulkar-msft 4b36165
corrcted the template file path
dphulkar-msft 200cf9b
updated version for testing docker publish
dphulkar-msft 9f453d6
updated template file
dphulkar-msft 1eb7cb1
updated template file
dphulkar-msft f40595e
updated pipeline file
dphulkar-msft d48a36b
Updated template code
dphulkar-msft ad4e042
Updated template code
dphulkar-msft ced196d
Updated template code
dphulkar-msft e11cc52
Updated template code
dphulkar-msft 89f4125
Updated template code
dphulkar-msft 5ec5b12
Updated template code
dphulkar-msft 41358a3
Updated template code
dphulkar-msft 90f48e0
Updated template code
dphulkar-msft 25b5d15
Updated template code
dphulkar-msft 3263893
reverted not required changes
dphulkar-msft 2b21a96
Merge branch 'main' into dphulkar/dockerMarinerArm64Support
wonwuakpa-msft 4ed0217
Merge branch 'main' into dphulkar/dockerMarinerArm64Support
wonwuakpa-msft File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
# Create container based on mariner 2.0 image | ||
FROM --platform=linux/arm64 mcr.microsoft.com/cbl-mariner/base/core:2.0 | ||
|
||
# Install dependencies | ||
RUN tdnf update -y | ||
RUN tdnf install -y ca-certificates | ||
|
||
# Copy azcopy binary to executable path | ||
COPY ./azcopy /usr/local/bin/ | ||
|
||
# Make azcopy executable | ||
RUN chmod +x /usr/local/bin/azcopy | ||
|
||
WORKDIR /azcopy | ||
CMD [ "azcopy" ] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,60 @@ | ||
parameters: | ||
- name: jobName | ||
type: string | ||
- name: useDemands | ||
type: boolean | ||
- name: matrix | ||
type: object | ||
- name: ubuntu_tag | ||
type: string | ||
- name: mariner_tag | ||
type: string | ||
|
||
jobs: | ||
- job: ${{ parameters.jobName }} | ||
timeoutInMinutes: 120 | ||
strategy: | ||
matrix: ${{ parameters.matrix }} | ||
pool: | ||
${{ if eq(parameters.useDemands, true) }}: | ||
name: "blobfuse-ubn-arm64-pool" | ||
demands: | ||
- ImageOverride -equals ${{ parameters.matrix['Ubuntu_arm64'].agentName }} | ||
${{ if eq(parameters.useDemands, false) }}: | ||
vmImage: ${{ parameters.matrix['Ubuntu_amd64'].vmImage }} | ||
|
||
variables: | ||
- group: AZCOPY_SECRET_VAULT | ||
- name: root_dir | ||
value: '$(System.DefaultWorkingDirectory)' | ||
- name: work_dir | ||
value: '$(System.DefaultWorkingDirectory)/azure-storage-azcopy' | ||
|
||
steps: | ||
- checkout: self | ||
|
||
- ${{ if eq(parameters.jobName, 'Set_2_Ubuntu_Mariner_ARM64') }}: | ||
- task: ShellScript@2 | ||
inputs: | ||
scriptPath: "$(work_dir)/go_installer.sh" | ||
args: "$(root_dir)/ $(AZCOPY_GOLANG_VERSION)" | ||
displayName: "Installing Go tools" | ||
|
||
- ${{ if eq(parameters.jobName, 'Set_2_Ubuntu_Mariner_ARM64') }}: | ||
- script: | | ||
sudo apt update | ||
sudo apt --fix-broken install | ||
displayName: "Install dependencies" | ||
|
||
- script: | | ||
chmod 777 *.sh | ||
./dockerinstall.sh | ||
|
||
# Build and publish Docker containers | ||
./buildcontainer.sh Dockerfile ${{ parameters.ubuntu_tag }} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Shouldn't the Dockerfile names be passed in as an arg? Same with Mariner below |
||
./publishcontainer.sh $(AZCOPY_DOCKER_REG_USER) $(AZCOPY_DOCKER_REG_PWD) ${{ parameters.ubuntu_tag }} | ||
|
||
./buildcontainer.sh DockerfileMariner ${{ parameters.mariner_tag }} | ||
./publishcontainer.sh $(AZCOPY_DOCKER_REG_USER) $(AZCOPY_DOCKER_REG_PWD) ${{ parameters.mariner_tag }} | ||
displayName: "Create docker image and push to the containers registry" | ||
workingDirectory: $(work_dir)/docker |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can probably do this for all the cases, this should be safe to do even in the distros that we didn't need this for