Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass executor template configuration through the ApplicationGroup spec #188

Open
nitishm opened this issue Apr 28, 2021 · 3 comments
Open
Assignees
Labels
chore Chores size : M Scoped out tasks of medium size
Milestone

Comments

@nitishm
Copy link
Contributor

nitishm commented Apr 28, 2021

Currently the default executor is hardcoded,

func defaultExecutor(timeout time.Duration) v1alpha12.Template {
	executorArgs := []string{"--spec", "{{inputs.parameters.helmrelease}}", "--timeout", timeout.String()}
	return v1alpha12.Template{
		Name:               helmReleaseExecutor,
		ServiceAccountName: workflowServiceAccountName(),
		Inputs: v1alpha12.Inputs{
			Parameters: []v1alpha12.Parameter{
				{
					Name: "helmrelease",
				},
			},
		},
		Executor: &v1alpha12.ExecutorConfig{
			ServiceAccountName: workflowServiceAccountName(),
		},
		Outputs: v1alpha12.Outputs{},
		Container: &corev1.Container{
			Name:  "executor",
			Image: "azureorkestra/executor:v0.1.0",
			Args:  executorArgs,
		},
	}
}

Rather than using a static template we should pass the container configuration through the ApplicationGroup spec.

@nitishm nitishm added the chore Chores label Apr 28, 2021
@nitishm nitishm self-assigned this Apr 29, 2021
@nitishm nitishm added the size : M Scoped out tasks of medium size label Apr 29, 2021
@nitishm nitishm added this to the Milestone #2 milestone Jun 14, 2021
@nitishm
Copy link
Contributor Author

nitishm commented Jun 23, 2021

@mahalrs will you be willing to take on this? This requires API changes. We can discuss this if you would like on slack

The idea is to replace the static WorkflowExecutor with a dynamically configurable executor through the ApplicationGroup CR.

@nitishm
Copy link
Contributor Author

nitishm commented Jun 23, 2021

@jonathan-innis this would allow us to test any changes to the default workflow executor as well as any new executors without having to modify the orkestra controller source code.

@mahalrs
Copy link
Contributor

mahalrs commented Jun 23, 2021

@mahalrs will you be willing to take on this? This requires API changes. We can discuss this if you would like on slack

The idea is to replace the static WorkflowExecutor with a dynamically configurable executor through the ApplicationGroup CR.

Let's discuss it on slack.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Chores size : M Scoped out tasks of medium size
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants