Pass executor template configuration through the ApplicationGroup spec
#360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's not done yet but @nitishm can you have a look. |
|
Hey @mahalrs hows this coming along? LMK if need any help |
jonathan-innis
suggested changes
Jul 14, 2021
| // Subcharts provides the dependency order among the subcharts of the application | ||
| // +optional | ||
| Subcharts []DAG `json:"subcharts,omitempty"` | ||
| } | ||
|
|
||
| type Executor struct { |
There was a problem hiding this comment.
@nitishm Let me try and understand the scenario here, is the idea that someone will customize the executor/docker image per-application group? What is the viable scenario for this? Can we not use a single docker image and then dynamically adjust the checks we do within that executable?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #188