Skip to content

Commit

Permalink
adding test for msbuild formatter
Browse files Browse the repository at this point in the history
  • Loading branch information
mmv committed Jan 27, 2016
1 parent b951ff5 commit 19563b5
Show file tree
Hide file tree
Showing 3 changed files with 68 additions and 0 deletions.
9 changes: 9 additions & 0 deletions test/files/formatters/msbuildFormatter.test.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
module ProseModule {
export class ProseClass {
private name: string;

constructor(name: string) {
this.name = name;
}
}
}
57 changes: 57 additions & 0 deletions test/formatters/msbuildFormatterTests.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,57 @@
/*
* Copyright 2013 Palantir Technologies, Inc.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

import * as ts from "typescript";
import {IFormatter, RuleFailure, TestUtils} from "../lint";

describe("MSBuild Formatter", () => {
const TEST_FILE = "formatters/msbuildFormatter.test.ts";
let sourceFile: ts.SourceFile;
let formatter: IFormatter;

before(() => {
const Formatter = TestUtils.getFormatter("msbuild");
sourceFile = TestUtils.getSourceFile(TEST_FILE);
formatter = new Formatter();
});

it("formats failures", () => {
const maxPosition = sourceFile.getFullWidth();

const failures = [
new RuleFailure(sourceFile, 0, 1, "first failure", "first-name"),
new RuleFailure(sourceFile, 32, 36, "mid failure", "mid-name"),
new RuleFailure(sourceFile, maxPosition - 1, maxPosition, "last failure", "last-name")
];

const expectedResult =
getFailureString(TEST_FILE, 1, 1, "first failure") +
getFailureString(TEST_FILE, 2, 12, "mid failure") +
getFailureString(TEST_FILE, 9, 2, "last failure");

const actualResult = formatter.format(failures);
assert.equal(actualResult, expectedResult);
});

it("handles no failures", () => {
const result = formatter.format([]);
assert.equal(result, "\n");
});

function getFailureString(file: string, line: number, character: number, reason: string) {
return `${file}(${line},${character}): warning: ${reason}\n`;
}
});
2 changes: 2 additions & 0 deletions test/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@
"../src/formatters.ts",
"../src/formatters/index.ts",
"../src/formatters/jsonFormatter.ts",
"../src/formatters/msbuildFormatter.ts",
"../src/formatters/pmdFormatter.ts",
"../src/formatters/proseFormatter.ts",
"../src/formatters/verboseFormatter.ts",
Expand Down Expand Up @@ -125,6 +126,7 @@
"utils.ts",
"formatters/externalFormatterTest.ts",
"formatters/jsonFormatterTests.ts",
"formatters/msbuildFormatterTests.ts",
"formatters/pmdFormatterTests.ts",
"formatters/proseFormatterTests.ts",
"formatters/verboseFormatterTests.ts",
Expand Down

0 comments on commit 19563b5

Please sign in to comment.