refactor(campaign)!: remove refundable parameter #7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Highly opinionated change.
Campaigns have this
refundable
field which is only checked in thecancel
function. In order tocancel
a campaign, the admin has to first call theset_refundable
function to toggle the field to true. Once the field is true, it can never be flipped back to false.The value of
set_refundable: false
does not provide any additional security guarantees because the admin of the contract or owner of the campaign can always call theset_refundable
function to toggle it to true. Once set to true, it can never be flipped back to false.However, having to set the
refundable
field to true manually by executing a separate function call is annoying and a waste of gas/compute. It would be simpler to have campaigns that are always cancellable/refundable.BREAKING CHANGE: Remove
refundable
parameter from campaigns.