Skip to content

Commit

Permalink
Use "replaceable" instead of "optIntoRbf" in fundrawtransaction.
Browse files Browse the repository at this point in the history
To be consistent with other RPCs
  • Loading branch information
TheBlueMatt committed Jul 5, 2017
1 parent 928c681 commit fb915d5
Showing 1 changed file with 5 additions and 4 deletions.
9 changes: 5 additions & 4 deletions src/wallet/rpcwallet.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -2655,7 +2655,8 @@ UniValue fundrawtransaction(const JSONRPCRequest& request)
" Those recipients will receive less bitcoins than you enter in their corresponding amount field.\n"
" If no outputs are specified here, the sender pays the fee.\n"
" [vout_index,...]\n"
" \"optIntoRbf\" (boolean, optional) Allow this transaction to be replaced by a transaction with higher fees\n"
" \"replaceable\" (boolean, optional) Marks this transaction as BIP125 replaceable.\n"
" Allows this transaction to be replaced by a transaction with higher fees\n"
" }\n"
" for backward compatibility: passing in a true instead of an object will result in {\"includeWatching\":true}\n"
"\nResult:\n"
Expand Down Expand Up @@ -2707,7 +2708,7 @@ UniValue fundrawtransaction(const JSONRPCRequest& request)
{"reserveChangeKey", UniValueType(UniValue::VBOOL)},
{"feeRate", UniValueType()}, // will be checked below
{"subtractFeeFromOutputs", UniValueType(UniValue::VARR)},
{"optIntoRbf", UniValueType(UniValue::VBOOL)},
{"replaceable", UniValueType(UniValue::VBOOL)},
},
true, true);

Expand Down Expand Up @@ -2741,8 +2742,8 @@ UniValue fundrawtransaction(const JSONRPCRequest& request)
if (options.exists("subtractFeeFromOutputs"))
subtractFeeFromOutputs = options["subtractFeeFromOutputs"].get_array();

if (options.exists("optIntoRbf")) {
coinControl.signalRbf = options["optIntoRbf"].get_bool();
if (options.exists("replaceable")) {
coinControl.signalRbf = options["replaceable"].get_bool();
}
}
}
Expand Down

0 comments on commit fb915d5

Please sign in to comment.