Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Now the Model type is usable by class that extends Viewer #16118

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

alexandremottet
Copy link
Contributor

@alexandremottet alexandremottet commented Jan 28, 2025

Before
If you extend Viewer and call _loadModel you cannot use the type Model anywhere in the extended class.

Now
You can use the type Model

@bjsplat
Copy link
Collaborator

bjsplat commented Jan 28, 2025

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Jan 28, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Jan 28, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Jan 28, 2025

@ryantrem ryantrem merged commit a030078 into BabylonJS:master Jan 28, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants