Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent duplicate notifications for removed anchors in WebXRAnchorSystem #16210

Merged
merged 1 commit into from
Feb 24, 2025

Conversation

RaananW
Copy link
Member

@RaananW RaananW commented Feb 24, 2025

Implement a mechanism to track removed anchors, preventing duplicate notifications when anchors are removed from the session. This change introduces an internal flag to indicate if an anchor has already been removed.

Fixes the issue presented here - https://forum.babylonjs.com/t/anchorsystem-anchor-remove-causes-crash-on-android/51672?u=raananw

@bjsplat
Copy link
Collaborator

bjsplat commented Feb 24, 2025

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Feb 24, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Feb 24, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Feb 24, 2025

@RaananW RaananW merged commit 23fed40 into BabylonJS:master Feb 24, 2025
15 checks passed
@RaananW RaananW deleted the anchorDeleteAfterRequest branch February 24, 2025 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants