Do not add a stray comma to the JSON for meshes and nodes if custom p…

…roperty not one of the types that can be handled (#68) Co-authored-by: Markus Wagner <[email protected]> The trailing else just looks like standard defensive code that should have been put in. Nothing weird to handle this Cycles issue. Good Job. Will not get to getting this on the repo's .zip today, but you should not be impacted . Thanks!
BabylonJS · Aug 25, 2023 · dbdf9bf · dbdf9bf
1 parent 63ed1d9
commit dbdf9bf
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/src/babylon_js/mesh.py b/src/babylon_js/mesh.py
@@ -610,6 +610,9 @@ def writeCustomProperties(self, file_handler):
             if type(v) == str: write_string(file_handler, k, v, noComma)
             elif type(v) == float: write_float(file_handler, k, v, FLOAT_PRECISION_DEFAULT, noComma)
             elif type(v) == int: write_int(file_handler, k, v, noComma)
+            else:
+              Logger.warn('Non-scalar custom prop "' + k + '" ignored.', 2)
+              continue
             noComma = False
         file_handler.write('}')
 

diff --git a/src/babylon_js/node.py b/src/babylon_js/node.py
@@ -54,5 +54,8 @@ def writeCustomProperties(self, file_handler):
             if type(v) == str: write_string(file_handler, k, v, noComma)
             elif type(v) == float: write_float(file_handler, k, v, noComma)
             elif type(v) == int: write_int(file_handler, k, v, noComma)
+            else:
+              Logger.warn('Non-scalar custom prop "' + k + '" ignored.', 2)
+              continue
             noComma = False
         file_handler.write('}')