Merge pull request sonata-project#3407 from pulzarraider/autocompl_extd

Removed type check of sonata_type_model_autocomplete to allow extending the form type.
BacLuc · Nov 6, 2015 · 03f72ae · 03f72ae
2 parents c61f7c7 + b08e87d
commit 03f72ae
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 12 deletions.
diff --git a/Controller/HelperController.php b/Controller/HelperController.php
@@ -462,10 +462,6 @@ private function retrieveFormFieldDescription(AdminInterface $admin, $field)
             throw new \RuntimeException(sprintf('The field "%s" does not exist.', $field));
         }
 
-        if ($fieldDescription->getType() !== 'sonata_type_model_autocomplete') {
-            throw new \RuntimeException(sprintf('Unsupported form type "%s" for field "%s".', $fieldDescription->getType(), $field));
-        }
-
         if (null === $fieldDescription->getTargetEntity()) {
             throw new \RuntimeException(sprintf('No associated entity with field "%s".', $field));
         }

diff --git a/Tests/Controller/HelperControllerTest.php b/Tests/Controller/HelperControllerTest.php
@@ -537,10 +537,6 @@ public function testRetrieveAutocompleteItemsActionDisabledFormelememt()
 
         $fieldDescription = $this->getMock('Sonata\AdminBundle\Admin\FieldDescriptionInterface');
 
-        $fieldDescription->expects($this->once())
-            ->method('getType')
-            ->will($this->returnValue('sonata_type_model_autocomplete'));
-
         $fieldDescription->expects($this->once())
             ->method('getTargetEntity')
             ->will($this->returnValue('Sonata\AdminBundle\Tests\Fixtures\Bundle\Entity\Foo'));
@@ -610,10 +606,6 @@ public function testRetrieveAutocompleteItemsActionNotGrantedTarget()
 
         $fieldDescription = $this->getMock('Sonata\AdminBundle\Admin\FieldDescriptionInterface');
 
-        $fieldDescription->expects($this->once())
-            ->method('getType')
-            ->will($this->returnValue('sonata_type_model_autocomplete'));
-
         $fieldDescription->expects($this->once())
             ->method('getTargetEntity')
             ->will($this->returnValue('Sonata\AdminBundle\Tests\Fixtures\Bundle\Entity\Foo'));