lint task: update scripts/eslint.js sharing code with linc.js; (faceb…

…ook#11518)

* (build infrastructure): unify lint and linc buid task;

* Fail on warnings

* Fail on warnings

scripts/eslint/index.js

@@ -0,0 +1,19 @@
+/**
+ * Copyright (c) 2013-present, Facebook, Inc.
+ *
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
+ */
+
+'use strict';
+
+const CLIEngine = require('eslint').CLIEngine;
+const cli = new CLIEngine();
+const formatter = cli.getFormatter();
+
+module.exports = function lintOnFiles(filePatterns) {
+  const report = cli.executeOnFiles(filePatterns);
+  const formatedResults = formatter(report.results);
+  console.log(formatedResults);
+  return report;
+};

scripts/tasks/eslint.js

@@ -7,24 +7,11 @@
 
 'use strict';
 
-var path = require('path');
-var spawn = require('child_process').spawn;
-
-var extension = process.platform === 'win32' ? '.cmd' : '';
-
-spawn(
-  path.join('node_modules', '.bin', 'eslint' + extension),
-  ['.', '--max-warnings=0'],
-  {
-    // Allow colors to pass through
-    stdio: 'inherit',
-  }
-).on('close', function(code) {
-  if (code !== 0) {
-    console.error('Lint failed');
-  } else {
-    console.log('Lint passed');
-  }
-
-  process.exit(code);
-});
+const lintOnFiles = require('../eslint');
+const report = lintOnFiles(['.']);
+if (report.errorCount > 0 || report.warningCount > 0) {
+  console.log('Lint failed.');
+  process.exit(1);
+} else {
+  console.log('Lint passed.');
+}

scripts/tasks/linc.js

@@ -7,12 +7,8 @@
 
 'use strict';
 
+const lintOnFiles = require('../eslint');
 const execFileSync = require('child_process').execFileSync;
-const CLIEngine = require('eslint').CLIEngine;
-
-const cli = new CLIEngine();
-const formatter = cli.getFormatter();
-
 const mergeBase = execFileSync('git', ['merge-base', 'HEAD', 'master'], {
   stdio: 'pipe',
   encoding: 'utf-8',
@@ -30,10 +26,8 @@ const changedFiles = execFileSync(
   .split('\n');
 const jsFiles = changedFiles.filter(file => file.match(/.js$/g));
 
-const report = cli.executeOnFiles(jsFiles);
-console.log(formatter(report.results));
-
-if (report.errorCount > 0) {
+const report = lintOnFiles(jsFiles);
+if (report.errorCount > 0 || report.warningCount > 0) {
   console.log('Lint failed for changed files.');
   process.exit(1);
 } else {