Skip to content

Commit

Permalink
audit: reorder AUDIT_TTY_SET arguments
Browse files Browse the repository at this point in the history
An admin is likely to want to see old and new values next to each other.
Putting all of the old values followed by all of the new values is just
hard to read as a human.

Signed-off-by: Eric Paris <[email protected]>
  • Loading branch information
eparis committed Jan 14, 2014
1 parent 0e23bac commit 1ce319f
Showing 1 changed file with 4 additions and 7 deletions.
11 changes: 4 additions & 7 deletions kernel/audit.c
Original file line number Diff line number Diff line change
Expand Up @@ -1010,13 +1010,10 @@ static int audit_receive_msg(struct sk_buff *skb, struct nlmsghdr *nlh)
spin_unlock(&tsk->sighand->siglock);

audit_log_common_recv_msg(&ab, AUDIT_CONFIG_CHANGE);
audit_log_format(ab, " op=tty_set"
" old-enabled=%d old-log_passwd=%d"
" new-enabled=%d new-log_passwd=%d"
" res=%d",
old.enabled, old.log_passwd,
s.enabled, s.log_passwd,
!err);
audit_log_format(ab, " op=tty_set old-enabled=%d new-enabled=%d"
" old-log_passwd=%d new-log_passwd=%d res=%d",
old.enabled, s.enabled, old.log_passwd,
s.log_passwd, !err);
audit_log_end(ab);
break;
}
Expand Down

0 comments on commit 1ce319f

Please sign in to comment.