crypto: sha512 - Fix byte counter overflow in SHA-512

The current code only increments the upper 64 bits of the SHA-512 byte counter when the number of bytes hashed happens to hit 2^64 exactly. This patch increments the upper 64 bits whenever the lower 64 bits overflows. Signed-off-by: Kent Yoder <[email protected]> Cc: [email protected] Signed-off-by: Herbert Xu <[email protected]>
Baughn · Apr 5, 2012 · 25c3d30 · 25c3d30
1 parent 5219a53
commit 25c3d30
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/crypto/sha512_generic.c b/crypto/sha512_generic.c
@@ -174,7 +174,7 @@ sha512_update(struct shash_desc *desc, const u8 *data, unsigned int len)
 	index = sctx->count[0] & 0x7f;
 
 	/* Update number of bytes */
-	if (!(sctx->count[0] += len))
+	if ((sctx->count[0] += len) < len)
 		sctx->count[1]++;
 
         part_len = 128 - index;