Skip to content

Commit

Permalink
[PATCH] USB: fix hid core to return proper error code from probe
Browse files Browse the repository at this point in the history
Drivers need to return -ENODEV when they can't bind to a device.
Anything else stops the "bind a device to a driver" search.

From: Stelian Pop <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
  • Loading branch information
stelian42 authored and gregkh committed Jun 23, 2005
1 parent b7c84c6 commit 479f6ea
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions drivers/usb/input/hid-core.c
Original file line number Diff line number Diff line change
Expand Up @@ -1762,7 +1762,7 @@ static int hid_probe(struct usb_interface *intf, const struct usb_device_id *id)
intf->altsetting->desc.bInterfaceNumber);

if (!(hid = usb_hid_configure(intf)))
return -EIO;
return -ENODEV;

hid_init_reports(hid);
hid_dump_device(hid);
Expand All @@ -1777,7 +1777,7 @@ static int hid_probe(struct usb_interface *intf, const struct usb_device_id *id)
if (!hid->claimed) {
printk ("HID device not claimed by input or hiddev\n");
hid_disconnect(intf);
return -EIO;
return -ENODEV;
}

printk(KERN_INFO);
Expand Down

0 comments on commit 479f6ea

Please sign in to comment.