make utf8 bytes response not reuse thread local buffer

no need, optimized conversion to bytes anyhow, and when sending, it will just get wrapped by a buffer
Besbash · Jul 6, 2013 · 4574489 · 4574489
1 parent f4d1895
commit 4574489
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 11 deletions.
diff --git a/src/main/java/org/elasticsearch/rest/StringRestResponse.java b/src/main/java/org/elasticsearch/rest/StringRestResponse.java
@@ -27,13 +27,6 @@
  */
 public class StringRestResponse extends Utf8RestResponse {
 
-    private static ThreadLocal<BytesRef> cache = new ThreadLocal<BytesRef>() {
-        @Override
-        protected BytesRef initialValue() {
-            return new BytesRef();
-        }
-    };
-
     public StringRestResponse(RestStatus status) {
         super(status);
     }
@@ -43,7 +36,7 @@ public StringRestResponse(RestStatus status, String content) {
     }
 
     private static BytesRef convert(String content) {
-        BytesRef result = cache.get();
+        BytesRef result = new BytesRef();
         UnicodeUtil.UTF16toUTF8(content, 0, content.length(), result);
         return result;
     }

diff --git a/src/main/java/org/elasticsearch/rest/Utf8RestResponse.java b/src/main/java/org/elasticsearch/rest/Utf8RestResponse.java
@@ -25,8 +25,6 @@
  * An http response that is built on top of {@link org.apache.lucene.util.BytesRef}.
  * <p/>
  * <p>Note, this class assumes that the utf8 result is not thread safe.
- *
- *
  */
 public class Utf8RestResponse extends AbstractRestResponse implements RestResponse {
 
@@ -58,7 +56,7 @@ public Utf8RestResponse(RestStatus status, BytesRef utf8Result,
 
     @Override
     public boolean contentThreadSafe() {
-        return false;
+        return true;
     }
 
     @Override