Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use distinct TOC files #103

Merged
merged 1 commit into from
Aug 26, 2021
Merged

Use distinct TOC files #103

merged 1 commit into from
Aug 26, 2021

Conversation

p3lim
Copy link
Collaborator

@p3lim p3lim commented Jul 26, 2021

This fixes an issue where the packager fails to run when specifying game version and using distinct TOC files:

> cat Addon-Classic.toc
## Interface: 11307
...

> ./release.sh -g classic
Addon TOC interface version is not compatible with the game version "classic" or was not found.

@p3lim p3lim requested a review from nebularg July 26, 2021 13:45
@Meorawr
Copy link
Contributor

Meorawr commented Jul 30, 2021 •
edited
Loading

This'll need updating for the new TOC suffixes, and needs to be backwards compatible with the existing ones.

@p3lim p3lim merged commit 4a3ceab into master Aug 26, 2021
@p3lim p3lim mentioned this pull request Aug 26, 2021
Merged
@p3lim p3lim deleted the fix-distinct-toc branch September 10, 2021 18:28
@p3lim p3lim mentioned this pull request Sep 10, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nebularg nebularg Awaiting requested review from nebularg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@p3lim @Meorawr