Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding "current" game interface version and small script to update (multi)tocs according to these values #117

Closed
wants to merge 5 commits into from

Conversation

mooreatv
Copy link

Note that this isn't supporting single toc with multiple interface lines and also assume your "main" toc is either a symlink or copied during build from -Mainline.toc (as it isn't updated by the script)

@Meorawr
Copy link
Contributor

Meorawr commented Feb 22, 2022

I don't see why this needs to be part of the packager repository considering it doesn't integrate into the action itself. It'd be better to make this a completely separate action that people can opt-into in their own workflows.

Other issues:

  • As it's missing support for updating Interface-<Client> directives in TOC files, it won't work with workflows using the TOC auto-generation flag (-S).
  • The "current" interface version being auto-decided from a text file is problematic as the game has Beta, PTR, and Live servers with different interface versions.
  • Deciding when to update the "current" version list is extremely complicated.
    • If you update the "current" versions too eagerly users of this script in their workflow can be in a situation where, if they need to push an update for the current patch prior to the next ones release, it will mis-identify as supporting the next patch. This can cause a few issues; updater clients might eagerly not offer downloads for a game version the user doesn't yet have, or the package itself might not actually work on release date of the new patch.
    • If you update the "current" versions too late, regional release dates of patches become a problem. Packages made just prior to - or during - US maintenance might upload with the wrong older interface version if the current version list hasn't been updated in time despite actually being intended to target the new patch.

@nebularg
Copy link
Member

I've played around with ways of automating this, but I think something like https://github.com/p3lim/toc-interface-updater is a better way to handle it

@nebularg
Copy link
Member

nebularg commented Mar 4, 2022

Gonna close this. I think it's fine if someone wants to include something like this in their build process, but I've always shied away from automating interface versions with the packager itself

@nebularg nebularg closed this Mar 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants