Preliminary 3.4.0 Support #123
Conversation
- Evidence in datamining has shown `_Wrath` to be the new suffix, hence it's preliminary implementation. CF Releases fallback to TBC's Game Type ID, to prevent accidental releases as Retail and since the API is closer based to 9.2.5 and TBC then anything else.
There was a problem hiding this comment.
Nitpick: All your added lines are indented with spaces, whereas the rest of the file uses tabs.
I'm not sure defaulting to the TBC game ID for CF without the warning message being printed is a good idea as that could lead to surprises for any addons that need client-specific packages.
|
If CF doesn't support Wrath yet then shouldn't uploading Wrath packages to CF just be disabled until they support it? |
For packages that explicitly only support and target Wrath, yes - to me it'd make no sense to upload such a package to a platform that doesn't support that game version. For multi-client packages that support versions other than but including Wrath, no - it should just flag it as supporting the other game versions and log a warning stating that the packager was only able to mark compatibility with a subset of the supported game versions. |
|
Fixed up the indents and added a clearer message/warning for while CF doesn't support wrath. Presumably, if we just dont want it to upload to CF at all as wrath, then I'd assume the id assignment could just be removed or made invalid. Either way, up to you all 👍 |
|
Thanks for doing the work to get this ready 😛 Everything looks fine, but I'll probably sit on this for a bit until we actually get some wrath support/servers |
|
Happy to help. At most, the only change thatll be needed to thos after merging is adding the curseforge game type once cf implements it, and possibly adding a few aliases for -Wrath depending on how devs end up packaging releases (In a perfect world, theyd all use -Wrath, but looking at the aliases bcc uses, its unlikely) |
|
There won't be a need for any TOC suffix aliases; they only exist for Classic Era/TBC because Blizzard changed the original pair of suffixes in a patch after some addons had already started using the older ones. |
|
Per #126 and some manual digging it seems we got a suffix alias anyway - |
|
There will need to be a fix much like there is |
|
Ill implement both these either later today or tomorrow morning, depending on time. Thanks for letting me know :) |
|
Bit late, but I've adjusted the pr for Cheers! |
|
No worries, addons aren't enabled yet and only wago supports it :p |
|
Addon Support for WOTLK is now Live on the Beta, Let the games begin! |
Credits to Qartemis for the find, should hopefulyl allow CF uploads pending any further issues
|
Confirmed tested and working. |
|
Ah yeah, forgot to comment: On behalf of commit |
|
Thank you for your service, sir |
_Wrathto be the new suffix, hence it's preliminary implementation.CF Releases fallback to TBC's Game Type ID, to prevent accidental releases as Retail and since the API is closer based to 9.2.5 and TBC then anything else.