Update TOC interface parsing to allow for 6 digit interface versions #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With Retail moving to 10.0, Interface versions are expected to change to 6 digits, with a 2 digit major version in the front. Adjust the parsing of the interface version to accomodate for this.
|
oh neat, i didn't realize adding the extra space let the start index be negative and avoid the clash with the 'use if unset' expansion and ended up with |
mooreatv
pushed a commit
to mooreatv/packager
that referenced
this pull request
Oct 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With Retail moving to 10.0, Interface versions are expected to change to
6 digits, with a 2 digit major version in the front. Adjust the parsing
of the interface version to accomodate for this.