Make release.sh executable #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows CI scripts to more easily execute the script without using `bash release.sh` syntax, or chmod it themselves
p3lim
approved these changes
Apr 6, 2020
|
Not that this change is bad in any form, and should be merged, but I do have to wonder if "bash release.sh" is really considered complicated :D |
Nevcairiel
approved these changes
Apr 6, 2020
When running the script without any arguments, I definitely agree. This is more for when I want to run the script with multiple arguments, not having to use the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows CI scripts to more easily execute the script without using
bash release.shsyntax, or chmodding the script in the CI