Add support for BC on Wago #81
Conversation
| @@ -83,7 +83,7 @@ usage() { | |||
| echo " -p curse-id Set the project id used on CurseForge for localization and uploading. (Use 0 to unset the TOC value)" >&2 | |||
| echo " -w wowi-id Set the addon id used on WoWInterface for uploading. (Use 0 to unset the TOC value)" >&2 | |||
| echo " -a wago-id Set the project id used on Wago Addons for uploading. (Use 0 to unset the TOC value)" >&2 | |||
| echo " -g game-version Set the game version to use for CurseForge uploading." >&2 | |||
| echo " -g game-version Set the game version to use for CurseForge and Wago uploading (currently supports 'classic' and 'bc')." >&2 | |||
There was a problem hiding this comment.
-g also supports specificying an actual version directly (eg. -g 1.13.7), so the help update is not accurate
| @@ -154,6 +154,8 @@ while getopts ":celLzusop:dw:a:r:t:g:m:" opt; do | |||
| # shortcut for classic | |||
| if [ "$OPTARG" = "classic" ]; then | |||
| game_type="classic" | |||
| elif [ "$OPTARG" = "bc" ]; then | |||
| game_type="bc" | |||
| # game_version from toc | |||
| else | |||
| # Set version (x.y.z) | |||
There was a problem hiding this comment.
The block following this can set the game_type based on the specified version and should handle BC versions as well, and similarly there is a TOC-based detection further down in the file as well that needs updating for proper BC support.
|
Adding support for a separate BC tag currently isn't useful until we know how Blizzard plans on handling the BC client. If there's a unified client between classic and BC, there will be no separate category, you will be loading the exact same addons. |
|
That's fair @funkydude , I will close the PR for now and reopen in case there is an official commitment from Blizzard on the client setup. |
|
Added BC support in 2963e10 |
This adds support for the
bcgame type.The PR is kept in draft state as the API is not yet published and will be made available as soon as this PR is ready to merge.