Skip to content

Commit

Permalink
Add a fixme to resetTargetOptions to explain why it needs to go
Browse files Browse the repository at this point in the history
away.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@236009 91177308-0d34-0410-b5e6-96231b3b80d8
  • Loading branch information
echristo committed Apr 28, 2015
1 parent a4944e5 commit 5d88757
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions lib/Target/TargetMachine.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,11 @@ TargetMachine::~TargetMachine() {
}

/// \brief Reset the target options based on the function's attributes.
// FIXME: This function needs to go away for a number of reasons:
// a) global state on the TargetMachine is terrible in general,
// b) there's no default state here to keep,
// c) these target options should be passed only on the function
// and not on the TargetMachine (via TargetOptions) at all.
void TargetMachine::resetTargetOptions(const Function &F) const {
#define RESET_OPTION(X, Y) \
do { \
Expand Down

0 comments on commit 5d88757

Please sign in to comment.