Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error handling #35

Merged
merged 4 commits into from
May 13, 2020
Merged

Error handling #35

merged 4 commits into from
May 13, 2020

Conversation

Billzabob
Copy link
Owner

Mostly 3 unrelated changes:

  • Refactored build.sbt to match what I saw in other open source libs. It doesn't make too much of a difference now but it'll be nice when we add a documentation page.
  • Changed error handling so that it fails right away and the stack trace has more info about the failure. For example, now you'll see that Discord reports Invalid shard. in the output because we were sending null for the shard field on Identify (see next bullet).
  • Quick temporary fix to the Identify encoder issue involving nulls seen in Discord doesn't treat null JSON fields and absent JSON fields the same #29.

@codecov
Copy link

codecov bot commented May 11, 2020

Codecov Report

Merging #35 into master will decrease coverage by 4.87%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #35      +/-   ##
==========================================
- Coverage   50.37%   45.50%   -4.88%     
==========================================
  Files          59       59              
  Lines         397      400       +3     
==========================================
- Hits          200      182      -18     
- Misses        197      218      +21     
Impacted Files Coverage Δ
src/main/scala/dissonance/Discord.scala 0.00% <0.00%> (ø)
src/main/scala/dissonance/Main.scala 0.00% <0.00%> (ø)
...ain/scala/dissonance/model/identify/Identify.scala 0.00% <0.00%> (ø)
src/main/scala/dissonance/model/embed/Field.scala 0.00% <0.00%> (-100.00%) ⬇️
src/main/scala/dissonance/model/embed/Image.scala 0.00% <0.00%> (-100.00%) ⬇️
src/main/scala/dissonance/model/embed/Video.scala 0.00% <0.00%> (-100.00%) ⬇️
src/main/scala/dissonance/model/embed/Author.scala 0.00% <0.00%> (-100.00%) ⬇️
src/main/scala/dissonance/model/embed/Footer.scala 0.00% <0.00%> (-100.00%) ⬇️
...c/main/scala/dissonance/model/embed/Provider.scala 0.00% <0.00%> (-100.00%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dfeb378...e121624. Read the comment docs.

@Billzabob Billzabob requested a review from hogiyogi597 May 12, 2020 13:58
@Billzabob Billzabob merged commit 47ea608 into master May 13, 2020
@Billzabob Billzabob deleted the error-handling branch May 14, 2020 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants