Parse as embed update if parsing as message fails #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closes #32 |
Codecov Report
@@ Coverage Diff @@
## master #37 +/- ##
==========================================
+ Coverage 50.37% 50.62% +0.24%
==========================================
Files 59 60 +1
Lines 397 399 +2
==========================================
+ Hits 200 202 +2
Misses 197 197
Continue to review full report at Codecov.
|
hogiyogi597
reviewed
May 13, 2020
| ) extends Update | ||
|
|
||
| implicit val config: Configuration = Configuration.default.withSnakeCaseMemberNames | ||
| implicit val updateDecoder: Decoder[Update] = Decoder[Message].map(Edit).widen[Update] or deriveConfiguredDecoder[EmbedUpdate].widen[Update] |
There was a problem hiding this comment.
Interesting. So widen basically casts to a supertype?
Also, where does this or come from? Is that from circe?
There was a problem hiding this comment.
Ya I actually want to understand it better because I forgot what makes it legal , remind me to ask in Gitter tomorrow. Ya the or comes from Circe 👍
hogiyogi597
previously approved these changes
May 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.